Difference between revisions of "Svn practices"

From Apache OpenOffice Wiki
Jump to: navigation, search
(Created page with "This page is still under review. 1) Read-only access. This is meant for people that don't know that well what version control is but want to grab the code and play with it. It …")
 
(replaced links to incubator pages)
 
(66 intermediate revisions by 3 users not shown)
Line 1: Line 1:
This page is still under review.
+
'''This page is under review. This line will be removed after it is done.'''
  
1) Read-only access. This is meant for people that
+
This page gathered svn practices frequently used by contributors and committers. If you have any advice to this page, please feel free to update it or discuss your idea in ooo-dev mail list.
don't know that well what version control is but
+
want to grab the code and play with it.
+
  
It should contain how to do a checkout, update
+
SVN Client 1.7 is recommanded to use for AOO development. It's strongly recommended use alternative name for svn's subcommand, like co-checkout, ci-commit, up-update, di-diff, and so on.
your tree, what the branches are and how to
+
apply, revert or generate patches, It's
+
actually a good practice to use svn diff to
+
generate patches as it contains the information
+
of the specific revision used to generate it.
+
  
2) Write access. There is a guide for new committers:
+
__TOC__
http://www.apache.org/dev/new-committers-guide.html
+
  
But I actually think that a quick guide that explains
+
==Read-only access==
how to set the default properties and how to do the
+
*Grab the whole source code from main trunk
simple tasks would be great. My tips here are
+
  
I highly recommend:
+
<source lang="bash">
 +
svn co https://svn.apache.org/repos/asf/openoffice/trunk aoo
 +
</source>
  
1) specifying in the command line a list of the
+
*Grab a branch
files/dirs that are changed to avoid accidentally
+
committing unwanted changes.
+
  
2) Use of a template for the log file with the
+
<source lang="bash">
author and other information.
+
svn co https://svn.apache.org/repos/asf/openoffice/branches/AOO410 aoo410
This is wrong:
+
</source>
svn commit -m "My changes"
+
This is right:
+
svn commit ci -F ../mychangelog.txt change1 change2
+
  
3) Remind people to add the revision information
+
*Grab a specific directory from a branch
in Bugzilla for crossreference, if it applies.
+
  
This chapter should also explain how to create
+
<source lang="bash">
branches for bigger tasks and how to merge
+
svn co https://svn.apache.org/repos/asf/openoffice/branches/AOO410/main/sw sw
changes to a branch.
+
</source>
  
For reference, FreeBSD has a SVN Primer,
+
This gets the source code for Writer module (named "sw") from the AOO410 branch
and the Merging section has some complete
+
 
instructions:
+
*Get the latest changes into your working copy
 +
 
 +
Change into the working directory such as aoo or sw for the above case and run
 +
svn update
 +
This command will merge the public changes with the local changes if there are any.
 +
 
 +
*Update to a specific revision
 +
 
 +
svn update -r xxxx
 +
 
 +
*Check changes history
 +
 
 +
svn log<br />
 +
svn log filename
 +
 
 +
Also show information about the paths that were changed in each displayed revision.
 +
svn log -v
 +
 
 +
Show for specific revision.
 +
svn log -r m
 +
 
 +
*Organize logical changes by changelist
 +
Use cl instead of changelist for convenience.
 +
 
 +
svn changelist tocload-feature filename1 filename2 ...
 +
 
 +
*Check changes and create a patch from local changes
 +
When creating patch, combine all your changes into a patch.
 +
 
 +
The path in patch should at least start in "main" or top directory.
 +
 
 +
svn diff filename1 filename2 > n.patch
 +
 
 +
*Create patch from a specific revision:
 +
 
 +
svn diff -c m > n.patch
 +
 
 +
*For changes consisting of many revisions n..m use
 +
 
 +
svn diff -r m:n > n.patch
 +
instead.
 +
 
 +
*Discard local changes and revert to unmodified state
 +
 
 +
svn revert
 +
 
 +
==Write access==
 +
*Apply patch when review other's code change
 +
Make sure current directory is consistent with path in patch, like "main".
 +
 
 +
svn patch n.patch
 +
 
 +
Reverse patch:
 +
 
 +
svn patch --reverse-diff n.patch
 +
 
 +
*Check changes before committing them
 +
 
 +
svn status
 +
and / or
 +
svn diff
 +
svn diff --changelist tocload-feature
 +
 
 +
*Commit your changes
 +
Don't forget to specify the list of files/dirs that are changed to avoid accidentally committing unwanted changes.
 +
 
 +
svn commit -m "comment" [filenames]
 +
svn commit -m "comment" --changelist tocload-feature
 +
 
 +
*Committing a patch
 +
Prepare a commit-comment file (e.g. mychangelog.txt) by using the relevant parts of this template:
 +
 
 +
  Patch by:
 +
  Suggested by:
 +
  Found by:
 +
  Review by:
 +
  Tested by:
 +
 
 +
and then commit it by running either
 +
svn commit -F mychangelog.txt [filenames]
 +
svn commit -F mychangelog.txt --changelist tocload-feature
 +
 
 +
*Update Bugzilla
 +
Update [https://issues.apache.org/ooo/ bugzilla] with revision information for cross reference when you are done with the commit and know the revision numbers.
 +
 
 +
== Working with a branch ==
 +
There at least two situations that you need to work with a branch.
 +
* If the changes you are about to make are complicated or you want to share them with others during development.
 +
 
 +
* There are interesting upstream branches created by others. For example, after AOO 3.4 is released, a branch for the AOO 3.4.x micro releases was created.
 +
 
 +
Instead of doing 'svn commit' both on trunk and the release branch use 'svn merge' if your fix needs to be submitted to both code lines.
 +
 
 +
There are also other cases in which you don't want to commit in development mainline directly.
 +
 
 +
*How to create a branch
 +
 
 +
<source lang="bash">
 +
svn copy https://svn.apache.org/repos/asf/openoffice/trunk  \
 +
          https://svn.apache.org/repos/asf/openoffice/branches/tocloading \
 +
      -m "Creating a private branch for toc loading of word document."
 +
</source>
 +
 
 +
*Keep a branch in sync
 +
Subversion is aware of the history of your branch and knows when it split away from the mainline. To perform a sync merge, first make sure your working copy of the branch is “clean”—that it has no local modifications reported by 'svn status'. Then simply run:
 +
 
 +
$ pwd
 +
/home/user/tocloading
 +
$ svn merge ^/ooo/trunk
 +
 
 +
*Reintegrate a branch
 +
When your new feature is done. It needs to be merged back to mainline. Before do that, sync the brache with mainline and commit your changes. Then
 +
 
 +
$ svn merge --reintegrate ^/ooo/branches/tocloading
 +
 
 +
and commit again
 +
 
 +
*Remove a branch
 +
Once a branch is integrated back it has become useless and can be removed.
 +
 
 +
$ svn delete ^/ooo/branches/tocloading -m "Remove branch of toc loading"
 +
 
 +
==Reference==
 +
SVN Basics
 +
http://openoffice.apache.org/svn-basics.html
 +
 
 +
A guide for new committers:
 +
http://www.apache.org/dev/new-committers-guide.html
 +
 
 +
Merge Instruction from FreeBSD:
 
http://wiki.freebsd.org/SubversionPrimer/Merging
 
http://wiki.freebsd.org/SubversionPrimer/Merging
  
Of course FreeBSD is more complex in structure
+
SVN book:
and has many more committers so some additional
+
http://svnbook.red-bean.com/en/1.7/svn-book.html
rules are in place:
+
 
 +
SVN Best Practices
 +
http://svn.apache.org/repos/asf/subversion/trunk/doc/user/svn-best-practices.html
  
In general we don't commit things directly
+
[[Category:Documentation]]
to the branches unless we have to and in that
+
case the Release Engineer has to approve the
+
change. There's no such thing as lazy consensus
+
there ;). We also set as minimum three days (I
+
usually take a couple of weeks) before merging
+
any change to the stable branch.
+

Latest revision as of 13:37, 24 March 2014

This page is under review. This line will be removed after it is done.

This page gathered svn practices frequently used by contributors and committers. If you have any advice to this page, please feel free to update it or discuss your idea in ooo-dev mail list.

SVN Client 1.7 is recommanded to use for AOO development. It's strongly recommended use alternative name for svn's subcommand, like co-checkout, ci-commit, up-update, di-diff, and so on.

Read-only access

  • Grab the whole source code from main trunk
svn co https://svn.apache.org/repos/asf/openoffice/trunk aoo
  • Grab a branch
svn co https://svn.apache.org/repos/asf/openoffice/branches/AOO410 aoo410
  • Grab a specific directory from a branch
svn co https://svn.apache.org/repos/asf/openoffice/branches/AOO410/main/sw sw

This gets the source code for Writer module (named "sw") from the AOO410 branch

  • Get the latest changes into your working copy

Change into the working directory such as aoo or sw for the above case and run

svn update

This command will merge the public changes with the local changes if there are any.

  • Update to a specific revision
svn update -r xxxx
  • Check changes history
svn log
svn log filename

Also show information about the paths that were changed in each displayed revision.

svn log -v

Show for specific revision.

svn log -r m
  • Organize logical changes by changelist

Use cl instead of changelist for convenience.

svn changelist tocload-feature filename1 filename2 ...
  • Check changes and create a patch from local changes

When creating patch, combine all your changes into a patch.

The path in patch should at least start in "main" or top directory.

svn diff filename1 filename2 > n.patch
  • Create patch from a specific revision:
svn diff -c m > n.patch
  • For changes consisting of many revisions n..m use
svn diff -r m:n > n.patch

instead.

  • Discard local changes and revert to unmodified state
svn revert

Write access

  • Apply patch when review other's code change

Make sure current directory is consistent with path in patch, like "main".

svn patch n.patch

Reverse patch:

svn patch --reverse-diff n.patch
  • Check changes before committing them
svn status

and / or

svn diff
svn diff --changelist tocload-feature
  • Commit your changes

Don't forget to specify the list of files/dirs that are changed to avoid accidentally committing unwanted changes.

svn commit -m "comment" [filenames]
svn commit -m "comment" --changelist tocload-feature
  • Committing a patch

Prepare a commit-comment file (e.g. mychangelog.txt) by using the relevant parts of this template:

  Patch by:
  Suggested by:
  Found by:
  Review by:
  Tested by:

and then commit it by running either

svn commit -F mychangelog.txt [filenames]
svn commit -F mychangelog.txt --changelist tocload-feature
  • Update Bugzilla

Update bugzilla with revision information for cross reference when you are done with the commit and know the revision numbers.

Working with a branch

There at least two situations that you need to work with a branch.

  • If the changes you are about to make are complicated or you want to share them with others during development.
  • There are interesting upstream branches created by others. For example, after AOO 3.4 is released, a branch for the AOO 3.4.x micro releases was created.

Instead of doing 'svn commit' both on trunk and the release branch use 'svn merge' if your fix needs to be submitted to both code lines.

There are also other cases in which you don't want to commit in development mainline directly.

  • How to create a branch
 svn copy https://svn.apache.org/repos/asf/openoffice/trunk  \
           https://svn.apache.org/repos/asf/openoffice/branches/tocloading \
      -m "Creating a private branch for toc loading of word document."
  • Keep a branch in sync

Subversion is aware of the history of your branch and knows when it split away from the mainline. To perform a sync merge, first make sure your working copy of the branch is “clean”—that it has no local modifications reported by 'svn status'. Then simply run:

$ pwd
/home/user/tocloading 
$ svn merge ^/ooo/trunk
  • Reintegrate a branch

When your new feature is done. It needs to be merged back to mainline. Before do that, sync the brache with mainline and commit your changes. Then

$ svn merge --reintegrate ^/ooo/branches/tocloading

and commit again

  • Remove a branch

Once a branch is integrated back it has become useless and can be removed.

$ svn delete ^/ooo/branches/tocloading -m "Remove branch of toc loading"

Reference

SVN Basics http://openoffice.apache.org/svn-basics.html

A guide for new committers: http://www.apache.org/dev/new-committers-guide.html

Merge Instruction from FreeBSD: http://wiki.freebsd.org/SubversionPrimer/Merging

SVN book: http://svnbook.red-bean.com/en/1.7/svn-book.html

SVN Best Practices http://svn.apache.org/repos/asf/subversion/trunk/doc/user/svn-best-practices.html

Personal tools