BuildingMSVCStandard

From Apache OpenOffice Wiki
Revision as of 21:43, 11 January 2006 by Thorsten (Talk | contribs)

Jump to: navigation, search

Code changes

What hides these issues when using Professional is more agressive inlining. Even if they all manifest with standard, they are actually separate and distinct issues. I've summarized the changes here and I'll add a patch once I've verified the impact of these changes. You have to do these changes before compiling --KaiB 22:13, 11 January 2006 (CET)

  • sj2/util/makefile.mk: add the SVTOOLLIB library
SHL1STDLIBS= \ 
$(VCLLIB) \ 
$(UNOTOOLSLIB) \ 
$(TOOLSLIB) \ 
$(CPPULIB) \ 
$(SALLIB) \ 
$(SVTOOLLIB) 
  • basic/source/apps/dialogs.cxx

1. Comment out the lines shown here starting from line 43:

//HACK( #define protected public )
//#define protected public		// Kleine Schweinerei um an FreeResource ranzukommen
#ifndef _TOOLS_RC_HXX //autogen
#include <tools/rc.hxx>
#endif
//#undef protected

2. Comment out the line shown here (line 238):

aConfig.EnablePersistence( FALSE );
// aTabCtrl.FreeResource();
FreeResource();

This seems like a policy error corrected by mauling the compiler? TODO: Contact Andreas Bregas and ask him if this can be removed. Thorsten informed that the code is from the initial OOo publish -- the change therefore happened in pre-OOo times.

Personal tools