Difference between revisions of "SQL Syntax Highlighting"
(→Colors) |
|||
(6 intermediate revisions by 3 users not shown) | |||
Line 12: | Line 12: | ||
The SQL view of the query designer, which displays, and allows to edit, raw SQL statements, currently is a mere text input field. It would be helpful especially to the unexperienced user to support the users by various means and make it more convinient. | The SQL view of the query designer, which displays, and allows to edit, raw SQL statements, currently is a mere text input field. It would be helpful especially to the unexperienced user to support the users by various means and make it more convinient. | ||
− | The cws for | + | The cws for the finished implementation was {{CWS|sqlsyntaxhighlighting}} |
==Detailed Information== | ==Detailed Information== | ||
Line 19: | Line 19: | ||
Five new features will be implemented: | Five new features will be implemented: | ||
− | * Syntax highlighting for the SQL view will be added: SQL keywords, literals and the like will be notable {{ | + | * Syntax highlighting for the SQL view will be added: SQL keywords, literals and the like will be notable {{Bug|67961}} |
− | * Syntax highlighting for the Tools | + | * Syntax highlighting for the {{menu|Tools|SQL…}} dialog {{Bug|95321}} |
− | * configurable colors in Tools | + | * configurable colors in {{menu|Tools|Options|General|Appearance}} {{Bug|95166}} |
− | * The SQL view will respect the settings from Tools | + | * The SQL view will respect the settings from {{menu|Tools|Options|OpenOffice|Fonts}}, where you can set a font name as well as a font size {{Bug|91687}} |
− | * To support users writing complex queries including bracket terms, matching characters will be shortly highlighted when pressing },)," or ' {{ | + | * To support users writing complex queries including bracket terms, matching characters will be shortly highlighted when pressing },)," or ' {{Bug|95165}} |
===Technical details=== | ===Technical details=== | ||
Line 121: | Line 121: | ||
===Colors=== | ===Colors=== | ||
− | <span style="color:# | + | <span style="color:#009900">SQLIDENTIFIER</span>: 009900 |
− | <span style="color:# | + | <span style="color:#000000">SQLNUMBER</span>: 000000 |
− | <span style="color:# | + | <span style="color:#CE7B00">SQLSTRING</span>: CE7B00 |
<span style="color:#000000">SQLOPERATOR</span>: 000000 | <span style="color:#000000">SQLOPERATOR</span>: 000000 | ||
− | <span style="color:# | + | <span style="color:#0000E6">SQLKEYWORD</span>: 0000E6 |
<span style="color:#259D9D">SQLPARAMETER</span>: 259D9D | <span style="color:#259D9D">SQLPARAMETER</span>: 259D9D | ||
− | <span style="color:# | + | <span style="color:#969696">SQLCOMMENT</span>: 969696 |
===People involved=== | ===People involved=== | ||
Line 191: | Line 191: | ||
== Migration == | == Migration == | ||
− | Old documents will | + | Old documents will work flawlessly with the new user interface. |
− | |||
== Configuration == | == Configuration == | ||
− | SQL colors can be configured in Tools | + | SQL colors can be configured in {{menu|Tools|Options|Appearance}} |
− | |||
==Future work== | ==Future work== |
Latest revision as of 10:14, 12 August 2022
Introduction
The SQL view of the query designer, which displays, and allows to edit, raw SQL statements, currently is a mere text input field. It would be helpful especially to the unexperienced user to support the users by various means and make it more convinient.
The cws for the finished implementation was CWS sqlsyntaxhighlighting
Detailed Information
Feature Description
Five new features will be implemented:
- Syntax highlighting for the SQL view will be added: SQL keywords, literals and the like will be notable Issue 67961
- Syntax highlighting for the Tools → SQL… dialog Issue 95321
- configurable colors in Tools → Options → General → Appearance Issue 95166
- The SQL view will respect the settings from Tools → Options → OpenOffice → Fonts, where you can set a font name as well as a font size Issue 91687
- To support users writing complex queries including bracket terms, matching characters will be shortly highlighted when pressing },)," or ' Issue 95165
Technical details
Instead of duplicating neccessary code for EditView/EditEngine/TextWindow again, a new control MultiLineEditSyntaxHighlight will be created, which will be derived from a MultiLineEdit, which actually already does all the EditView/EditEngine stuff already as a nice usable control. So this new control will be the same as a MultiLineEdit, but will be able to do the new stuff as well. As the current Base SQL view is using a MultiLineEdit already, it will be extremly easy to use the new control.
SQL strings
"all", "and", "any", "as", "asc", "avg", "between", "by", "cast", "corresponding", "count", "create", "cross", "delete", "desc", "distinct", "drop", "escape", "except", "exists", "false", "from", "full", "global", "group", "having", "in", "inner", "insert", "intersect", "into", "is", "join", "left", "like", "local", "match", "max", "min", "natural", "not", "null", "on", "or", "order", "outer", "right", "select", "set", "some", "sum", "table", "temporary", "true", "union", "unique", "unknown", "update", "using", "values", "where"
String additions and changes
resource | Old String | New String |
---|---|---|
fontsubs.src FL_SOURCEVIEW | "Font settings for HTML and Basic sources" ; | "Font settings for HTML, Basic and SQL sources" ; |
Colors
SQLIDENTIFIER: 009900
SQLNUMBER: 000000
SQLSTRING: CE7B00
SQLOPERATOR: 000000
SQLKEYWORD: 0000E6
SQLPARAMETER: 259D9D
SQLCOMMENT: 969696
People involved
Name | OOo Nickname | Role |
---|---|---|
Max Odendahl | mod | developer |
Frank Schönheit | fs | code reviewer / nitpicker |
Bettina Haberer | bh | UX |
Mechtilde Stehmann | mechtilde | QA |
André Schnabel | Thalion72 | QA |
File Format Changes
No changes to the file format is neccessary
Migration
Old documents will work flawlessly with the new user interface.
Configuration
SQL colors can be configured in Tools → Options → Appearance
Future work
end user
To further improve the usability, it would be nice to have the possibility to
- insert various SQL and user code snippets
- code completion including SQL keywords, table and field names
- FS:
How much effort would it be to allow an additional separate "class" (aka color) whose elements can be configured at runtime?
That is, at the moment both functions and SQL keywords use the same color, though they are different. The list of supported functions depends on the underlying database, and could be fed by the query designer into the SQL editor.
code base
If the BASIC IDE as well as HTML source view only need regular MultiLineEdit functionality, the new code could be used for these two cases as well. This would get rid of a lot of code and would make it more maintainable.